On Thu, Dec 4, 2014 at 11:27 AM, Marcel Holtmann <marcel@xxxxxxxxxxxx> wrote:
> Hi Jakub,
>
>>> This patch adds the opcode and structure for Start Service Discovery
>>> operation.
>>>
>>> Signed-off-by: Jakub Pawlowski <jpawlowski@xxxxxxxxxx>
>>> Signed-off-by: Marcel Holtmann <marcel@xxxxxxxxxxxx>
>>> ---
>>> include/net/bluetooth/mgmt.h | 9 +++++++++
>>> 1 file changed, 9 insertions(+)
>>>
>>> diff --git a/include/net/bluetooth/mgmt.h b/include/net/bluetooth/mgmt.h
>>> index 9b382ea34fd9..95c34d5180fa 100644
>>> --- a/include/net/bluetooth/mgmt.h
>>> +++ b/include/net/bluetooth/mgmt.h
>>> @@ -498,6 +498,15 @@ struct mgmt_cp_set_public_address {
>>> } __packed;
>>> #define MGMT_SET_PUBLIC_ADDRESS_SIZE 6
>>>
>>> +#define MGMT_OP_START_SERVICE_DISCOVERY 0x003A
>>> +struct mgmt_cp_start_service_discovery {
>>> + __u8 type;
>>
>> Maybe we should get rid of type ? service discovery based on
>> advertisement content makes sense only for LE
>
> this works perfectly fine for BR/EDR or BR/EDR + LE discovery. It is up to the call to decide what to do. And we have kept the type in place even for commands that are currently only supported on one transport. It allows us to extend the API without breaking it.
Ok, that sounds reasonable.
I've merged my filtering patch on top of your patches, then run
everything and did some manual tests - all works great!
I've just send updated patches.
>
> Regards
>
> Marcel
>
I
--
To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
