Re: [RFC 1/6] Bluetooth: Add HCI_RSSI_INVALID for unknown RSSI value

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Szymon,

>>>>> The Bluetooth core specification defines the value 127 as invalid for
>>>>> RSSI values. So instead of hard coding it, lets add a constant for it.
>>>>> 
>>>>> Signed-off-by: Marcel Holtmann <marcel@xxxxxxxxxxxx>
>>>>> ---
>>>>> include/net/bluetooth/hci.h | 1 +
>>>>> 1 file changed, 1 insertion(+)
>>>>> 
>>>>> diff --git a/include/net/bluetooth/hci.h b/include/net/bluetooth/hci.h
>>>>> index 569c077778b6..b6f7be1eb919 100644
>>>>> --- a/include/net/bluetooth/hci.h
>>>>> +++ b/include/net/bluetooth/hci.h
>>>>> @@ -412,6 +412,7 @@ enum {
>>>>> 
>>>>> /* The core spec defines 127 as the "not available" value */
>>>>> #define HCI_TX_POWER_INVALID	127
>>>>> +#define HCI_RSSI_INVALID	127
>>>> 
>>>> Isn't that value depending on command, event, link and controller type?
>>> 
>>> we use it for the mgmt side of things and there it is whatever we want it to be.
>> 
>> At least for inquiry result (no RSSI) 0 is passed to mgmt_device_found() and that seems
>> to be used by userspace as RSSI unavailable.
> 
> Which is strange btw, since both for LE and BR/EDR this is legal RSSI value...

I checked for LE. There is clearly says 127 means RSSI not available.

Regards

Marcel

--
To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Bluez Devel]     [Linux Wireless Networking]     [Linux Wireless Personal Area Networking]     [Linux ATH6KL]     [Linux USB Devel]     [Linux Media Drivers]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Big List of Linux Books]

  Powered by Linux