Hi Andrei, On Thu, Dec 4, 2014 at 10:15 AM, Andrei Emeltchenko <Andrei.Emeltchenko.news@xxxxxxxxx> wrote: > Hi Luiz, > > On Wed, Dec 03, 2014 at 08:35:41PM +0200, Luiz Augusto von Dentz wrote: >> Hi Andrei, >> >> On Wed, Dec 3, 2014 at 4:08 PM, Andrei Emeltchenko >> <Andrei.Emeltchenko.news@xxxxxxxxx> wrote: >> > From: Andrei Emeltchenko <andrei.emeltchenko@xxxxxxxxx> >> > >> > --- >> > unit/test-gatt.c | 4 ++-- >> > 1 file changed, 2 insertions(+), 2 deletions(-) >> > >> > diff --git a/unit/test-gatt.c b/unit/test-gatt.c >> > index 03a66b9..f20da91 100644 >> > --- a/unit/test-gatt.c >> > +++ b/unit/test-gatt.c >> > @@ -648,11 +648,11 @@ static void test_server(gconstpointer data) >> > >> > len = write(context->fd, pdu.data, pdu.size); >> > >> > + g_assert_cmpint(len, ==, pdu.size); >> > + >> > if (g_test_verbose()) >> > util_hexdump('<', pdu.data, len, test_debug, "GATT: "); >> > >> > - g_assert_cmpint(len, ==, pdu.size); >> > - >> > execute_context(context); >> > } >> > >> > -- >> > 1.9.1 >> >> What changes does this make? > > You do not use negative len in case of error in util_hexdump() Well then I guess this should be part of the path description. -- Luiz Augusto von Dentz -- To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html