Hi Harvey,
>> Actually there is a generic catch all entry for vendor 0x0489
>> already.
>>
>> /* Foxconn - Hon Hai */ { USB_VENDOR_AND_INTERFACE_INFO(0x0489,
>> 0xff, 0x01, 0x01) },
>>
>> So I prefer that we enable BTUSB_BCM_PATCHRAM support in a generic
>> way instead of just for every single product id.
>
> I have seen the other patch from Wen-chien Jesse Sung that does
> exactly this. But while I would prefer this way too I doubt that all
> firmware files come from the same place as these are vendor specific
> things. Mine i.e. was from a Fuijitsu support URL. So the commit
> message can not provide sources for firmware download in these generic
> way.
yes it can be in the commit message. Just clearly state what you are doing. Allowing for firmware download support does not mean that it is the same firmware. While you are enabling firmware download for the whole vendor class of the devices, the firmware extraction can be just described for a single product id. Just mention it in the commit message.
Regards
Marcel
--
To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
