From: Andrei Emeltchenko <andrei.emeltchenko@xxxxxxxxx> conn might be NULL and would be dereferenced in conn_set_key() This fixes coverity issue: ... conn = hci_conn_hash_lookup_ba(hdev, ACL_LINK, &ev->bdaddr); >>> CID: Dereference after null check (FORWARD_NULL) >>> Comparing "conn" to null implies that "conn" might be null. ... --- net/bluetooth/hci_event.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/bluetooth/hci_event.c b/net/bluetooth/hci_event.c index bd0a801..95f8057 100644 --- a/net/bluetooth/hci_event.c +++ b/net/bluetooth/hci_event.c @@ -3312,7 +3312,7 @@ static void hci_link_key_notify_evt(struct hci_dev *hdev, struct sk_buff *skb) /* Update connection information since adding the key will have * fixed up the type in the case of changed combination keys. */ - if (ev->key_type == HCI_LK_CHANGED_COMBINATION) + if (conn && ev->key_type == HCI_LK_CHANGED_COMBINATION) conn_set_key(conn, key->type, key->pin_len); mgmt_new_link_key(hdev, key, persistent); -- 1.9.1 -- To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
