Re: [PATCH 1/2] shared/gatt: Fix dereference before NULL check warnings

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



ping

On Thu, Nov 20, 2014 at 03:13:14PM +0200, Andrei Emeltchenko wrote:
> From: Andrei Emeltchenko <andrei.emeltchenko@xxxxxxxxx>
> 
> Add NULL check otherwise constructions like below give warnings:
> ...
> 	uint8_t pdu[4 + get_uuid_len(uuid)];
> 
> 	if (!att || !uuid || uuid->type == BT_UUID_UNSPEC)
> ...
> ---
>  src/shared/gatt-helpers.c | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/src/shared/gatt-helpers.c b/src/shared/gatt-helpers.c
> index d0bee3f..dc4a8e8 100644
> --- a/src/shared/gatt-helpers.c
> +++ b/src/shared/gatt-helpers.c
> @@ -588,6 +588,9 @@ static void put_uuid_le(const bt_uuid_t *src, void *dst)
>  
>  static inline int get_uuid_len(const bt_uuid_t *uuid)
>  {
> +	if (!uuid)
> +		return 0;
> +
>  	return (uuid->type == BT_UUID16) ? 2 : 16;
>  }
>  
> -- 
> 1.9.1
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in
> the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Bluez Devel]     [Linux Wireless Networking]     [Linux Wireless Personal Area Networking]     [Linux ATH6KL]     [Linux USB Devel]     [Linux Media Drivers]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Big List of Linux Books]

  Powered by Linux