[PATCH 1] obexd: Fix crash while session shutdown

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



g_str_equal has been used for the session path compare
which is not NULL-safe. Used the g_strcmp0() for the NULL-Safe
string comparision.

*#0 strcmp (p1=0x0, p2=0x7105c "/org/bluez/obex/client/session0")
*    at strcmp.c:38
*#1  0xb6e0cd0a in g_str_equal (v1=<value optimized out>,
*    v2=<value optimized out>) at ghash.c:1704
*#2  0x000264d8 in find_session (connection=<value optimized out>,
*    message=0x55b38, user_data=<value optimized out>)
*    at obexd/client/manager.c:162
*#3  remove_session (connection=<value optimized out>, message=0x55b38,
    user_data=<value optimized out>) at obexd/client/manager.c:231
---
 obexd/client/manager.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/obexd/client/manager.c b/obexd/client/manager.c
index 8efe1f2..7ae111c 100644
--- a/obexd/client/manager.c
+++ b/obexd/client/manager.c
@@ -157,7 +157,7 @@ static struct obc_session *find_session(const char *path)
 	for (l = sessions; l; l = l->next) {
 		struct obc_session *session = l->data;
 
-		if (g_str_equal(obc_session_get_path(session), path) == TRUE)
+		if (g_strcmp0(obc_session_get_path(session), path) == 0)
 			return session;
 	}
 
-- 
1.7.9.5

--
To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Bluez Devel]     [Linux Wireless Networking]     [Linux Wireless Personal Area Networking]     [Linux ATH6KL]     [Linux USB Devel]     [Linux Media Drivers]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Big List of Linux Books]

  Powered by Linux