Hi,
On Thursday 13 of November 2014 18:14:46 Szymon Janc wrote:
> Hi Łukasz,
>
> On Thursday 13 of November 2014 16:52:50 Lukasz Rymanowski wrote:
> > ---
> > android/handsfree.c | 21 ++++++++++++++-------
> > 1 file changed, 14 insertions(+), 7 deletions(-)
> >
> > diff --git a/android/handsfree.c b/android/handsfree.c
> > index 9a2fdd0..0001eb6 100644
> > --- a/android/handsfree.c
> > +++ b/android/handsfree.c
> > @@ -2038,24 +2038,31 @@ static void update_indicator(struct hf_device *dev, int ind, uint8_t val)
> > hfp_gw_send_info(dev->gw, "+CIEV: %u,%u", ind + 1, val);
> > }
> >
> > +static void device_status_notif(void *data, void *user_data)
> > +{
> > + struct hf_device *dev = data;
> > + struct hal_cmd_handsfree_device_status_notif *cmd = user_data;
>
> I think we should send this only to devices with SLC established.
This is handled by Framework anyway so I've applied patches 1 and 2. Thanks.
>
> > +
> > + update_indicator(dev, IND_SERVICE, cmd->state);
> > + update_indicator(dev, IND_ROAM, cmd->type);
> > + update_indicator(dev, IND_SIGNAL, cmd->signal);
> > + update_indicator(dev, IND_BATTCHG, cmd->battery);
> > +}
> > +
> > static void handle_device_status_notif(const void *buf, uint16_t len)
> > {
> > const struct hal_cmd_handsfree_device_status_notif *cmd = buf;
> > - struct hf_device *dev;
> > uint8_t status;
> >
> > DBG("");
> >
> > - dev = find_default_device();
> > - if (!dev) {
> > + if (queue_isempty(devices)) {
> > status = HAL_STATUS_FAILED;
> > goto done;
> > }
> >
> > - update_indicator(dev, IND_SERVICE, cmd->state);
> > - update_indicator(dev, IND_ROAM, cmd->type);
> > - update_indicator(dev, IND_SIGNAL, cmd->signal);
> > - update_indicator(dev, IND_BATTCHG, cmd->battery);
> > + /* Cast cmd to void as queue api needs that */
> > + queue_foreach(devices, device_status_notif, (void *) cmd);
> >
> > status = HAL_STATUS_SUCCESS;
> >
> >
>
>
--
Best regards,
Szymon Janc
--
To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
