Re: [PATCH BlueZ v2 05/11] shared/gatt-server: Implement "Read Blob" request.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Arman,

On Mon, Nov 10, 2014 at 09:07:21AM -0800, Arman Uguray wrote:
> This patch implements the "Read Blob" request for the GATT server role.
> ---
>  src/shared/gatt-server.c | 100 ++++++++++++++++++++++++++++++++++++++++-------
>  1 file changed, 85 insertions(+), 15 deletions(-)
> 

...

> +static void read_blob_cb(uint8_t opcode, const void *pdu,
> +					uint16_t length, void *user_data)
> +{
> +	struct bt_gatt_server *server = user_data;
> +	uint16_t handle, offset;
> +
> +	if (length != 4) {
> +		uint8_t pdu[4];

Can we avoid shadowing variables without any need?
This unfortunately became common practice for gatt code.

Best regards 
Andrei Emeltchenko 

--
To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Bluez Devel]     [Linux Wireless Networking]     [Linux Wireless Personal Area Networking]     [Linux ATH6KL]     [Linux USB Devel]     [Linux Media Drivers]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Big List of Linux Books]

  Powered by Linux