Re: [PATCH BlueZ v1 08/11] shared/gatt-server: Implement "Prepare Write" request.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Arman,

On Mon, Nov 10, 2014 at 6:26 PM, Arman Uguray <armansito@xxxxxxxxxxxx> wrote:
>>> diff --git a/src/shared/gatt-server.h b/src/shared/gatt-server.h
>>> index 0e480e1..a95613c 100644
>>> --- a/src/shared/gatt-server.h
>>> +++ b/src/shared/gatt-server.h
>>> @@ -40,6 +40,9 @@ bool bt_gatt_server_set_debug(struct bt_gatt_server *server,
>>>                                         void *user_data,
>>>                                         bt_gatt_server_destroy_func_t destroy);
>>>
>>> +bool bt_gatt_server_set_max_prep_queue_length(struct bt_gatt_server *server,
>>> +                                                       unsigned int length);
>>
>> Perhaps we should leave this API for later, Im not really sure if this
>> will be ever used except perhaps for the TS in that case perhaps we
>> should find a shorter name.
>>
>
> In our case would it even make sense to have a maximum queue length? I
> only added because there is an error for it and an application with
> memory constraints may want to limit the size perhaps? Anyway, for now
> I can set this to something arbitrary for v2.

Perhaps having some arbitrary limit is good enough, not exactly
because of memory constraints since each entry should consume just a
few bytes but we don't want to timeout so I suggest we queue based on
how long we should wait the result to be called.

-- 
Luiz Augusto von Dentz
--
To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Bluez Devel]     [Linux Wireless Networking]     [Linux Wireless Personal Area Networking]     [Linux ATH6KL]     [Linux USB Devel]     [Linux Media Drivers]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Big List of Linux Books]

  Powered by Linux