Re: [PATCH v3] Bluetooth: Fix sparse warning in amp.c

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Johan,

> This fixes the following sparse warning:
> 
> net/bluetooth/amp.c:152:53: warning: Variable length array is used.
> 
> The warning itself is probably harmless since this kind of usage of
> shash_desc is present also in other places in the kernel (there's even a
> convenience macro SHASH_DESC_ON_STACK available for defining such stack
> variables). However, dynamically allocated versions are also used in
> several places of the kernel (e.g. kernel/kexec.c and lib/digsig.c)
> which have the benefit of not exhibiting the sparse warning.
> 
> Since there are no more sparse warnings in the Bluetooth subsystem after
> fixing this one it is now easier to spot whenever new ones might get
> introduced by future patches.
> 
> Signed-off-by: Johan Hedberg <johan.hedberg@xxxxxxxxx>
> ---
> v3: Use correct location of kernel/kexec.c in commit message
> v2: Fix missing signed-off-by line
> 
> net/bluetooth/amp.c | 25 ++++++++++++++++---------
> 1 file changed, 16 insertions(+), 9 deletions(-)

patch has been applied to bluetooth-next tree.

Regards

Marcel

--
To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Bluez Devel]     [Linux Wireless Networking]     [Linux Wireless Personal Area Networking]     [Linux ATH6KL]     [Linux USB Devel]     [Linux Media Drivers]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Big List of Linux Books]

  Powered by Linux