Thanks for testing Jukka, I'll respin v2 later. Out of interest, did you have kmemleak on? - Martin. On 06/11/14 10:34, Jukka Rissanen wrote: > Hi Martin, > > On ti, 2014-11-04 at 21:36 +0000, Martin Townsend wrote: >> Currently we ensure that the skb is freed on every error path in IPHC >> decompression which makes it easy to introduce skb leaks. By centralising >> the skb_free into the receive function it makes future decompression routines >> easier to maintain. It does come at the expense of ensuring that the skb >> passed into the decompression routine must not be copied. > Tested this with real bluetooth hw and no issues were found. Just rebase > the patch with latest upstream (conflict had a very simple fix) so ack > with actions to v2. > > Acked-by: Jukka Rissanen <jukka.rissanen@xxxxxxxxxxxxxxx> > > > Cheers, > Jukka > > > -- > To unsubscribe from this list: send the line "unsubscribe linux-wpan" in > the body of a message to majordomo@xxxxxxxxxxxxxxx > More majordomo info at http://vger.kernel.org/majordomo-info.html -- To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html