Re: [PATCH v1 7/7] monitor/rfcomm: Add rfcomm file in Android.mk

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi,

On Mon, Nov 3, 2014 at 11:21 AM, Gowtham Anandha Babu
<gowtham.ab@xxxxxxxxxxx> wrote:
> Hi,
>
>> -----Original Message-----
>> From: Luiz Augusto von Dentz [mailto:luiz.dentz@xxxxxxxxx]
>> Sent: Monday, November 03, 2014 2:35 PM
>> To: Gowtham Anandha Babu
>> Cc: linux-bluetooth@xxxxxxxxxxxxxxx; Dmitry Kasatkin; Bharat Panda;
>> cpgs@xxxxxxxxxxx
>> Subject: Re: [PATCH v1 7/7] monitor/rfcomm: Add rfcomm file in Android.mk
>>
>> Hi,
>>
>> On Fri, Oct 31, 2014 at 5:08 PM, Gowtham Anandha Babu
>> <gowtham.ab@xxxxxxxxxxx> wrote:
>> > ---
>> >  android/Android.mk | 1 +
>> >  1 file changed, 1 insertion(+)
>> >
>> > diff --git a/android/Android.mk b/android/Android.mk index
>> > aefe41c..eebd863 100644
>> > --- a/android/Android.mk
>> > +++ b/android/Android.mk
>> > @@ -289,6 +289,7 @@ LOCAL_SRC_FILES := \
>> >         bluez/monitor/packet.c \
>> >         bluez/monitor/l2cap.c \
>> >         bluez/monitor/avctp.c \
>> > +       bluez/monitor/rfcomm.c \
>> >         bluez/monitor/uuid.c \
>> >         bluez/monitor/sdp.c \
>> >         bluez/monitor/vendor.c \
>> > --
>> > 1.9.1
>>
>> Usually we try very hard to avoid breaking the build even within the same
>> patch-set, so if possible please squash this change.
>>
>>
>> --
>> Luiz Augusto von Dentz
>
>
> Do you want me to send this one(Android.mk) as a separate patch (out of this patch-set) or merge this one to first patch ?

Please merge, you can use git commit --squash/--fixup=<patch> and then
git rebase --autosquash, there are actually many ways to do it.

-- 
Luiz Augusto von Dentz
--
To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Bluez Devel]     [Linux Wireless Networking]     [Linux Wireless Personal Area Networking]     [Linux ATH6KL]     [Linux USB Devel]     [Linux Media Drivers]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Big List of Linux Books]

  Powered by Linux