Re: [PATCHv3 1/7] shared/io: Remove disconnect handler in io_destroy

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Marcin,

On Fri, Oct 31, 2014 at 10:51 AM, Marcin Kraglak
<marcin.kraglak@xxxxxxxxx> wrote:
> Diconnect callback may be called after destroying IO in next
> mainloop iteration (it leada to reading freed data). Removing
> disconnect handler prevents that situation.
> ---
>  src/shared/io-glib.c | 5 +++++
>  1 file changed, 5 insertions(+)
>
> diff --git a/src/shared/io-glib.c b/src/shared/io-glib.c
> index a2ada66..5ebde3d 100644
> --- a/src/shared/io-glib.c
> +++ b/src/shared/io-glib.c
> @@ -115,6 +115,11 @@ void io_destroy(struct io *io)
>                 io->write_watch = 0;
>         }
>
> +       if (io->disconnect_watch > 0) {
> +               g_source_remove(io->disconnect_watch);
> +               io->disconnect_watch = 0;
> +       }
> +
>         g_io_channel_unref(io->channel);
>         io->channel = NULL;
>
> --
> 1.9.3

Applied, thanks.


-- 
Luiz Augusto von Dentz
--
To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Bluez Devel]     [Linux Wireless Networking]     [Linux Wireless Personal Area Networking]     [Linux ATH6KL]     [Linux USB Devel]     [Linux Media Drivers]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Big List of Linux Books]

  Powered by Linux