Hi Arman,
On Tue, Oct 28, 2014 at 11:59 PM, Arman Uguray <armansito@xxxxxxxxxxxx> wrote:
> Hi Luiz,
>
> On Tue, Oct 28, 2014 at 9:18 AM, Luiz Augusto von Dentz
> <luiz.dentz@xxxxxxxxx> wrote:
>> From: Luiz Augusto von Dentz <luiz.von.dentz@xxxxxxxxx>
>>
>> ---
>> src/shared/gatt-db.c | 20 +++++++++++++++++++-
>> 1 file changed, 19 insertions(+), 1 deletion(-)
>>
>> diff --git a/src/shared/gatt-db.c b/src/shared/gatt-db.c
>> index 19784d1..bfc7bfa 100644
>> --- a/src/shared/gatt-db.c
>> +++ b/src/shared/gatt-db.c
>> @@ -806,7 +806,25 @@ bool gatt_db_get_attribute_permissions(struct gatt_db *db, uint16_t handle,
>> struct gatt_db_attribute *gatt_db_get_attribute(struct gatt_db *db,
>> uint16_t handle)
>> {
>> - return NULL;
>> + struct gatt_db_service *service;
>> + uint16_t service_handle;
>> +
>> + if (!db || !handle)
>> + return NULL;
>> +
>> + service = queue_find(db->services, find_service_for_handle,
>> + INT_TO_PTR(handle));
>
> Shouldn't this be UINT_TO_PTR?
Yep, apparently it was broken in the original code as well, I will fix them.
>
>> + if (!service)
>> + return NULL;
>> +
>> + service_handle = service->attributes[0]->handle;
>> +
>> + /*
>> + * We can safely get attribute from attributes array with offset,
>> + * because find_service_for_handle() check if given handle is
>> + * in service range.
>> + */
>> + return service->attributes[handle - service_handle];
>> }
>>
>> uint16_t gatt_db_attribute_get_start_handle(struct gatt_db_attribute *attrib)
>> --
>> 1.9.3
>>
>> --
>> To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in
>> the body of a message to majordomo@xxxxxxxxxxxxxxx
>> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
> Cheers,
> Arman
--
Luiz Augusto von Dentz
--
To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
