Hi Luiz,
On Tue, Oct 28, 2014 at 9:18 AM, Luiz Augusto von Dentz
<luiz.dentz@xxxxxxxxx> wrote:
> From: Luiz Augusto von Dentz <luiz.von.dentz@xxxxxxxxx>
>
> ---
> src/shared/gatt-db.c | 7 ++++++-
> 1 file changed, 6 insertions(+), 1 deletion(-)
>
> diff --git a/src/shared/gatt-db.c b/src/shared/gatt-db.c
> index 9a3f864..f43cac3 100644
> --- a/src/shared/gatt-db.c
> +++ b/src/shared/gatt-db.c
> @@ -879,7 +879,12 @@ bool gatt_db_attribute_get_service_uuid(struct gatt_db_attribute *attrib,
> bool gatt_db_attribute_get_permissions(struct gatt_db_attribute *attrib,
> uint32_t *permissions)
> {
> - return false;
> + if (!attrib || !permissions)
> + return false;
So, based on my understanding, android/gatt treats an attribute
permission value of "0" as "this is a declaration attribute since we
didn't explicitly set it". Hence, returning 0 here will break things
in the android code once it starts using the gatt_db_attribute_*
functions.
That said, I don't like this logic one bit in the first place. Instead
of having "0" mean "anything goes" and having a special define for "no
permissions" (such as GATT_PERM_NONE from android/gatt and
BT_GATT_PERM from shared/att-types), we should just treat 0 to mean no
permissions. I.e. we should define BT_GATT_PERM_NONE as 0, and have
gatt_db_add_service, _add_characteristic, etc. explicitly set at least
the BT_GATT_PERM_READ permission on the declaration attributes.
In short we should unify the permission story for shared/gatt and
android/gatt sooner then later.
> +
> + *permissions = attrib->permissions;
> +
> + return true;
> }
>
> bool gatt_db_attribute_read(struct gatt_db_attribute *attrib, uint16_t offset,
> --
> 1.9.3
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in
> the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info at http://vger.kernel.org/majordomo-info.html
Cheers,
Arman
--
To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
