Hi Chan-yeol, > __hci_cmd_sync_ev(), __hci_req_sync() could miss wake_up_interrupt from > hci_req_sync_complete() because hci_cmd_work() workquee and its reponse > could be completed before they are ready to get the signal through > add_wait_queue(), set_current_state(TASK_INTERRUPTIBLE). > > Signed-off-by: Chan-yeol Park <chanyeol.park@xxxxxxxxxxx> > Signed-off-by: Kyungmin Park <kyungmin.park@xxxxxxxxxxx> > --- > net/bluetooth/hci_core.c | 18 +++++++++++------- > 1 file changed, 11 insertions(+), 7 deletions(-) > > diff --git a/net/bluetooth/hci_core.c b/net/bluetooth/hci_core.c > index cb05d7f..c008f1f 100644 > --- a/net/bluetooth/hci_core.c > +++ b/net/bluetooth/hci_core.c > @@ -1147,13 +1147,15 @@ struct sk_buff *__hci_cmd_sync_ev(struct hci_dev *hdev, u16 opcode, u32 plen, > > hdev->req_status = HCI_REQ_PEND; > > - err = hci_req_run(&req, hci_req_sync_complete); > - if (err < 0) > - return ERR_PTR(err); > - the whole patch has whitespace damages. Please fix this. Regards Marcel -- To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
