Hi Jukka, > Use spin_lock_bh() as the code is called from softirq in networking subsystem. > This is needed to prevent deadlocks when 6lowpan link is in use. > > Signed-off-by: Jukka Rissanen <jukka.rissanen@xxxxxxxxxxxxxxx> > --- > net/bluetooth/hci_core.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/net/bluetooth/hci_core.c b/net/bluetooth/hci_core.c > index cb05d7f..0242e01 100644 > --- a/net/bluetooth/hci_core.c > +++ b/net/bluetooth/hci_core.c > @@ -4662,7 +4662,7 @@ static void hci_queue_acl(struct hci_chan *chan, struct sk_buff_head *queue, > skb_shinfo(skb)->frag_list = NULL; > > /* Queue all fragments atomically */ > - spin_lock(&queue->lock); > + spin_lock_bh(&queue->lock); so I would actually prefer that we add a comment here why we need this. Since it is not obvious in this context that we might have a hci_send_acl from softirq. It really only happens with 6LoWPAN sending network packets since other L2CAP sockets will actually not trigger this. Regards Marcel -- To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
