Hi Martin,
On Thu, Oct 23, 2014 at 02:12:25PM +0100, Martin Townsend wrote:
...
> } else {
> switch (skb->data[0] & 0xe0) {
> case LOWPAN_DISPATCH_IPHC: /* ipv6 datagram */
> ret = process_data(skb, &hdr);
> if (ret == NET_RX_DROP)
> goto drop;
> - break;
> +
> + return lowpan_give_skb_to_devices(skb, NULL);
> case LOWPAN_DISPATCH_FRAG1: /* first fragment header */
> ret = lowpan_frag_rcv(skb, LOWPAN_DISPATCH_FRAG1);
> if (ret == 1) {
> ret = process_data(skb, &hdr);
> if (ret == NET_RX_DROP)
> goto drop;
> +
> + return lowpan_give_skb_to_devices(skb, NULL);
> + } else if (ret == -1) {
> + return NET_RX_DROP;
> + } else {
> + return NET_RX_SUCCESS;
> }
> break;
break isn't necessary here.
> case LOWPAN_DISPATCH_FRAGN: /* next fragments headers */
> @@ -558,6 +566,12 @@ static int lowpan_rcv(struct sk_buff *skb, struct net_device *dev,
> ret = process_data(skb, &hdr);
> if (ret == NET_RX_DROP)
> goto drop;
> +
> + return lowpan_give_skb_to_devices(skb, NULL);
> + } else if (ret == -1) {
> + return NET_RX_DROP;
> + } else {
> + return NET_RX_SUCCESS;
> }
> break;
same here.
You tagged this patch series as v3 but should be v4. Next series should
be v5.
- Alex
--
To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
