Hi Marcin, On Wed, Oct 22, 2014 at 9:25 AM, Marcin Kraglak <marcin.kraglak@xxxxxxxxx> wrote: > On 16 October 2014 12:17, Marcin Kraglak <marcin.kraglak@xxxxxxxxx> wrote: >> v3: >> In this version after primary service discovery, >> secondary services are discovered. Next included >> services are resolved. With this approach we >> don't have recursively search for included service, >> like it was TODO in previous proposal. >> There is also small coding style fix suggested by Arman. >> >> v4: >> If no secondary services found, continue include services search (fixed >> in gatt-client.c). >> Fixed wrong debug logs (primary->secondary). >> Fixed searching descriptors >> >> v5: >> Ignore Unsupported Group Type Error in response to secondary service >> discovery and continue included services discovery. >> >> Marcin Kraglak (14): >> shared/gatt: Add discover_secondary_services() >> shared/gatt: Add initial implementation of discover_included_services >> shared/gatt: Discover included services 128 bit UUIDS >> shared/gatt: Add extra check in characteristic iterator >> shared/gatt: Add included service iterator >> shared/gatt: Remove not needed function parameter >> shared/gatt: Distinguish Primary from Secondary services >> tools/btgatt-client: Print type of service >> shared/gatt: Discover secondary services >> shared/gatt: Discover included services >> shared/gatt: Add gatt-client include service iterator >> tools/btgatt-client: Print found include services >> shared/gatt: Fix searching descriptors >> shared/gatt: Add function bt_gatt_result_included_count() >> >> src/shared/gatt-client.c | 263 +++++++++++++++++++++++++++-- >> src/shared/gatt-client.h | 18 ++ >> src/shared/gatt-helpers.c | 418 +++++++++++++++++++++++++++++++++++++++++++--- >> src/shared/gatt-helpers.h | 10 +- >> tools/btgatt-client.c | 17 +- >> 5 files changed, 690 insertions(+), 36 deletions(-) >> >> -- >> 1.9.3 >> Patches looks fine to me, but I would like Arman to ack before applying. Btw, there is one thing I would like to see addressed, right now whenever we disconnect the cache is lost which doesn't use the CCC ability to persist across connections, this can cause us to loose notifications when reconnecting because the code don't remember any handles and this is specially bad for profiles such as HoG since we may loose some input events while rediscovering, in fact we should probably store the cache whenever the remote supports service changed and be able to reload them so we only have to do the discover again if something has changed. -- Luiz Augusto von Dentz -- To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
