Hi Arman, >>> This patch implements a version of GAttrib which is backed by >>> bt_att, which enables the simultaneous use of GAttrib and bt_att. >>> >>> This should enable smooth transition of profiles from the GAttrib >>> API to the src/shared bt_att API. >>> --- >>> Makefile.am | 8 +- >>> Makefile.tools | 11 +- >>> attrib/gattrib-shared.c | 306 ++++++++++++++++++++++++++++++++++++++++++++++++ >>> configure.ac | 4 + >>> 4 files changed, 327 insertions(+), 2 deletions(-) >>> create mode 100644 attrib/gattrib-shared.c >> >> to be honest, I would convert this in one go. If we can have a shim that just provides the GAttrib API, then lets use that and put it into src/ and remove attrib/ directory. >> > > Not sure what exactly you mean here by converting this in one go. > There is still a lot of code in attrib/ that is needed in conjunction > with GAttrib, such as all the ATT protocol encode/decode functions and > GATT procedure wrappers, so we are going to have to compile that stuff > in anyway and moving all of that into src/ doesn't make much sense to > me. So, for the shim, it made sense to put it in attrib/ initially. keeping it in attrib/ directory is fine with me as well. What I do not understand is why we need the compile time switch. Just for using bt_att underneath. Regards Marcel -- To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
