Hi Jakub, you really should not top-post on this mailing list. It breaks the flow for everybody else. > I started implementing service scanning and I have a questions: > > We initially agreed on version that uses le deduplication that needs > to be restarted after each device found. > When I started looking into that it's going to be much more restarting: > - need to restart after each packet from device that advertise service > we're interested that's not in RSSI range. That's because controller > that I use doesn't send advertisement again when RSSI changes. > - need to restart every 0.5 or 1 second in case when some device added > service I'm interested at to it's advertisement I think first we might need to have a HCI_QUIRK that we can set on hci_dev->quirks that tells us what kind of behavior the controller has. We can argue what is the expected default since the specification is pretty much unclear. Since for all known devices, we are using the whitelist, I am happy to accept that Broadcom controllers just need a quirk to restart scanning. We have to find a nice sweat spot on when to do it. So this would need some testing. So just go and play with it. My initial take would be that when you see a device with the matching filter, then you start a timeout. And after that timeout restart. Postpone the timeout if you find more devices that match your filter up to x seconds. That should get your there. > Can we conseider implementation using le scan without deduplication, > and do packet de-duplication in kernel in hci_le_adv_report_evt ? > I've started implementing it this way and it works really nice. The > issue here might be that it might consume more energy. If you get a really bad controller, then this will go ballistic. Trust me, we had this and some controllers will report every single advertising packet up to the host. You can not process this quickly enough. It gets worse if you have a peripheral that advertises with a high duty cycle. Then you will consume extra power. You need to test this in a real scenario where you actually have tons and tons peripherals around. It can get really bad. I mean it all depends on what you are actually want to do and how much precision you need. My first instinct is to just restart scanning to get new results. Regards Marcel -- To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
