On pe, 2014-10-17 at 16:08 +0200, Marcel Holtmann wrote:
> Hi Jukka,
>
> >> From: Li RongQing <roy.qing.li@xxxxxxxxx>
> >>
> >> netif_rx() only returns NET_RX_DROP and NET_RX_SUCCESS, not returns
> >> negative value
> >>
> >> Signed-off-by: Li RongQing <roy.qing.li@xxxxxxxxx>
> >> ---
> >> net/bluetooth/6lowpan.c | 9 +--------
> >> 1 file changed, 1 insertion(+), 8 deletions(-)
> >>
> >> diff --git a/net/bluetooth/6lowpan.c b/net/bluetooth/6lowpan.c
> >> index c2e0d14..9b5c89b 100644
> >> --- a/net/bluetooth/6lowpan.c
> >> +++ b/net/bluetooth/6lowpan.c
> >> @@ -249,19 +249,12 @@ static struct lowpan_dev *lookup_dev(struct l2cap_conn *conn)
> >> static int give_skb_to_upper(struct sk_buff *skb, struct net_device *dev)
> >> {
> >> struct sk_buff *skb_cp;
> >> - int ret;
> >>
> >> skb_cp = skb_copy(skb, GFP_ATOMIC);
> >> if (!skb_cp)
> >> return -ENOMEM;
> >>
> >> - ret = netif_rx(skb_cp);
> >> - if (ret < 0) {
> >> - BT_DBG("receive skb %d", ret);
> >> - return NET_RX_DROP;
> >> - }
> >> -
> >> - return ret;
> >> + return netif_rx(skb_cp);
> >> }
> >>
> >> static int process_data(struct sk_buff *skb, struct net_device *netdev,
> >
> > Ack to this.
> >
> > Signed-off-by: Jukka Rissanen <jukka.rissanen@xxxxxxxxxxxxxxx>
>
> this should be acked-by or reviewed-by and not signed-off-by. The signed-off-by is only if you would send Roy's original patch on his behalf or you would be in the chain of sending patches along the maintainer trees.
Do'h! Yep, I meant to say Acked-by (too many things going on same
time :)
Acked-by: Jukka Rissanen <jukka.rissanen@xxxxxxxxxxxxxxx>
>
> Regards
>
> Marcel
>
Cheers,
Jukka
--
To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
