Hi Luiz, > -----Original Message----- > From: Luiz Augusto von Dentz [mailto:luiz.dentz@xxxxxxxxx] > Sent: Thursday, October 16, 2014 1:48 PM > To: Gowtham Anandha Babu > Cc: linux-bluetooth@xxxxxxxxxxxxxxx; Dmitry Kasatkin; Bharat Panda; > cpgs@xxxxxxxxxxx > Subject: Re: [PATCH 1/4] tools/csr_usb : Fix Resource leak: file > > Hi, > > On Wed, Oct 15, 2014 at 5:08 PM, Gowtham Anandha Babu > <gowtham.ab@xxxxxxxxxxx> wrote: > > Handles resource leak. > > --- > > tools/csr_usb.c | 5 ++++- > > 1 file changed, 4 insertions(+), 1 deletion(-) > > > > diff --git a/tools/csr_usb.c b/tools/csr_usb.c index 5fb6bdc..a1d7324 > > 100644 > > --- a/tools/csr_usb.c > > +++ b/tools/csr_usb.c > > @@ -80,9 +80,12 @@ static int read_value(const char *name, const char > *attr, const char *format) > > return -1; > > > > n = fscanf(file, format, &value); > > - if (n != 1) > > + if (n != 1) { > > + fclose(file); > > return -1; > > + } > > > > + fclose(file); > > return value; > > } > > > > -- > > 1.9.1 > > Applied 1-3, but note that I did some changes in the commit message, please > be consistent and don't include things like space before ':' > etc, it is always a good practice got look how previous commit have been > formatted and follow the HACKING document. > > > -- > Luiz Augusto von Dentz Sorry for the formatting errors and 50/72 format. I will follow the HACKING documents here after. Thanks ! Regards, Gowtham Anandha Babu -- To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
