Re: [PATCH 02/10] android/map-client: Add stubs for MAP client commands handlers

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Szymon,

On 13 October 2014 21:58, Szymon Janc <szymon.janc@xxxxxxxxx> wrote:
> Hi Grzegorz,
>
> On Thursday 09 October 2014 14:45:06 Grzegorz Kolodziejczyk wrote:
>> Add empty handlers for MAP client IPC commands.
>> ---
>>  android/map-client.c | 33 ++++++++++++++++++++++++++++++++-
>>  1 file changed, 32 insertions(+), 1 deletion(-)
>>
>> diff --git a/android/map-client.c b/android/map-client.c
>> index 4556461..1001b36 100644
>> --- a/android/map-client.c
>> +++ b/android/map-client.c
>> @@ -28,17 +28,48 @@
>>  #include <stdbool.h>
>>  #include <stdlib.h>
>>  #include <stdint.h>
>> +#include <glib.h>
>>
>>  #include "ipc.h"
>>  #include "lib/bluetooth.h"
>>  #include "map-client.h"
>> +#include "src/log.h"
>> +#include "hal-msg.h"
>> +
>> +static struct ipc *hal_ipc = NULL;
>> +static bdaddr_t adapter_addr;
>> +
>> +static void handle_get_instances(const void *buf, uint16_t len)
>> +{
>> +     DBG("");
>> +
>> +     ipc_send_rsp(hal_ipc, HAL_SERVICE_ID_MAP_CLIENT,
>> +                     HAL_OP_MAP_CLIENT_GET_INSTANCES, HAL_STATUS_FAILED);
>> +}
>> +
>> +static const struct ipc_handler cmd_handlers[] = {
>> +     {handle_get_instances, false,
>> +                     sizeof(struct hal_cmd_map_client_get_instances)},
>
> Style issue: there should be spaces after { and before }.
> Also please add comment about define type just like in other handlers (I'm
> aware that there is just 1 handler here but lets be consistent).
>

Ok, I'll fix it.
>> +};
>>
>>  bool bt_map_client_register(struct ipc *ipc, const bdaddr_t *addr, uint8_t
>> mode) {
>> -     return false;
>> +     DBG("");
>> +
>> +     bacpy(&adapter_addr, addr);
>> +
>> +     hal_ipc = ipc;
>> +
>> +     ipc_register(hal_ipc, HAL_SERVICE_ID_MAP_CLIENT, cmd_handlers,
>> +                                             G_N_ELEMENTS(cmd_handlers));
>> +
>> +     return true;
>>  }
>>
>>  void bt_map_client_unregister(void)
>>  {
>> +     DBG("");
>>
>> +     ipc_unregister(hal_ipc, HAL_SERVICE_ID_MAP_CLIENT);
>> +     hal_ipc = NULL;
>>  }
>
> --
> Szymon K. Janc
> szymon.janc@xxxxxxxxx


Best regards,
Grzegorz
--
To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Bluez Devel]     [Linux Wireless Networking]     [Linux Wireless Personal Area Networking]     [Linux ATH6KL]     [Linux USB Devel]     [Linux Media Drivers]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Big List of Linux Books]

  Powered by Linux