Hi Alfonso, >>> + >>> + if (test_and_clear_bit(HCI_CONN_MODE_CHANGE_PEND, &conn->flags)) >>> + hci_conn_params_del(conn->hdev, &conn->dst, conn->dst_type); >>> } >>> >>> /* Enter sniff mode */ >>> @@ -544,6 +547,9 @@ int hci_conn_del(struct hci_conn *conn) >>> >>> hci_conn_del_sysfs(conn); >>> >>> + if (test_and_clear_bit(HCI_CONN_MODE_CHANGE_PEND, &conn->flags)) >>> + hci_conn_params_del(conn->hdev, &conn->dst, conn->dst_type); >> I suppose the above two test_and_clear_bit() calls should be operating >> on HCI_CONN_PARAM_REMOVAL_PEND and not HCI_CONN_MODE_CHANGE_PEND? > > Darn. Yes, my bad. don't we also need to clear the flag when the new pairing succeed? If we destroy hci_conn anyway, there is pretty much no point in test_and_clear_bit and we could just use test_bit here. Regards Marcel -- To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
