Hi, > -----Original Message----- > From: Luiz Augusto von Dentz [mailto:luiz.dentz@xxxxxxxxx] > Sent: Wednesday, October 08, 2014 6:01 PM > To: Gowtham Anandha Babu > Cc: linux-bluetooth@xxxxxxxxxxxxxxx; Dmitry Kasatkin; Bharat Panda; > cpgs@xxxxxxxxxxx > Subject: Re: [PATCH 5/6] obexd/messages: Add prototypes for MASInstance > response > > Hi, > > On Wed, Oct 8, 2014 at 3:09 PM, Gowtham Anandha Babu > <gowtham.ab@xxxxxxxxxxx> wrote: > > Hi, > > > >> -----Original Message----- > >> From: Luiz Augusto von Dentz [mailto:luiz.dentz@xxxxxxxxx] > >> Sent: Wednesday, October 08, 2014 4:42 PM > >> To: Gowtham Anandha Babu > >> Cc: linux-bluetooth@xxxxxxxxxxxxxxx; Dmitry Kasatkin; Bharat Panda; > >> cpgs@xxxxxxxxxxx > >> Subject: Re: [PATCH 5/6] obexd/messages: Add prototypes for > >> MASInstance response > >> > >> Hi, > >> > >> On Tue, Oct 7, 2014 at 7:06 AM, Gowtham Anandha Babu > >> <gowtham.ab@xxxxxxxxxxx> wrote: > >> > --- > >> > obexd/plugins/messages.h | 16 ++++++++++++++++ > >> > 1 file changed, 16 insertions(+) > >> > > >> > diff --git a/obexd/plugins/messages.h b/obexd/plugins/messages.h > >> > index > >> > 00a16b1..3aaeec1 100644 > >> > --- a/obexd/plugins/messages.h > >> > +++ b/obexd/plugins/messages.h > >> > @@ -307,3 +307,19 @@ int messages_set_delete(void *session, const > >> > char > >> *handle, uint8_t value, > >> > * session: Backend session. > >> > */ > >> > void messages_abort(void *session); > >> > + > >> > + > >> > + > >> > +/* Retrieves MAS Instance Information for the given mas-instance id. > >> > + * > >> > + * session: Backend session. > >> > + * mas_id: MAS Instance id requested by the MCE. > >> > + * > >> > + * Callback shall be called for every mas_instance_id request > >> > +received > >> from MCE. > >> > + */ > >> > +typedef void (*messages_mas_instance_info_cb)(void *session, int > err, > >> > + uint16_t size, const char *name, void *user_data); > >> > + > >> > +int messages_get_mas_instance_info(void *session, uint16_t > >> mas_instance_id, > >> > + messages_mas_instance_info_cb callback, > >> > + void *user_data); > >> > -- > >> > 1.9.1 > >> > >> You can drop using mas here since it is pretty obvious what it is > >> for, also Im not sure we need the size in the callback since we can use > strlen there. > >> > >> > >> -- > >> Luiz Augusto von Dentz > > > > I agree with you. I will update this comment for the patch[6/6] too. I will > include this in v2. Still is there anything to be handled? > > Start with the server side, I will be working on the client side to add support > for multiple instances, I have something already it just need some polishing. > > -- > Luiz Augusto von Dentz I think not much implementation in server side is needed. No features are using the instance id in server side except this patch set. But can be added as below: 1)Define no_of_mas_instance (assign no of instances if it supports or '0') 2)While MCE discovering for MAS service, advertise all mas id's(if it supports more than one) 3) While mas_connect(), need to look match for which mas_id the MCE requesting 4) Folder ordering for multiple MAS instance is needed as you suggested. Like MAS 1/telecom/... MAS 2/telecom/... Once the client part is known, we can implement that accordingly. Meanwhile is this patch set good to go? Regards, Gowtham Anandha Babu -- To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
