RE: [PATCH] Add signed write command

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



> >>> Add bt_att_set_csrk for btgatt-client tool. However this patch hook
> >>> into shared/mgmt, so btgatt-client now should be running by the root user.
> >>
> >> I guess this could be made optional.
> >
> > You said this could be made optional , what's you point ? I am not
> > very clear about That.
> 
> just provide a command line option to btgatt-client to provide the CSRK to be used.
> There is no need to attach to mgmt since that is only seeing keys during pairing
> anyway.

You means that let user get CSRK from DEVICE_FILE which stored CSRK value
when pairing, and put this CSRK into command line option by himself , right?
 
> >>> +
> >>> +void bt_att_set_csrk(struct bt_att *att,
> >>> +			const uint8_t *val,
> >>> +			uint32_t local_sign_cnt)
> >>
> >> This should allow to set local and/or remote csrk. Either we have two
> >> functions or flag identifying which key is provided.
> >
> > This is good idea. But this patch for client side, there is no need to
> > use remote_csrk, So would it be better to add remote csrk part when we need
> this?
> 
> I want to function. One to set the local CSRK and one for setting the remote CSRK.
> However I have no idea why we are bothering with the sign counter. Just reset it
> when creating bt_att.
> 
That's fine . I will implement it.

Best Regards
Chaojie Gu
--
To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Bluez Devel]     [Linux Wireless Networking]     [Linux Wireless Personal Area Networking]     [Linux ATH6KL]     [Linux USB Devel]     [Linux Media Drivers]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Big List of Linux Books]

  Powered by Linux