Re: [PATCH] Add signed write command

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Chaojie,

> Add bt_att_set_csrk for btgatt-client tool. However this patch hook into
> shared/mgmt, so btgatt-client now should be running by the root user.

As Szymon said, please split this patch into two: one for gatt-client
and one for the tool. Please use a proper commit message title for
each of them, prefixed with "shared/gatt-client:" and
"tools/btgatt_client:" respectively, with descriptive commit messages
for each patch.

It's also helpful if you add the -v flag when running git format-patch
to assign a version number to each iteration of the patch set. Makes
the reviews easier to keep track of. There are many examples of this
in the mailing list that you can refer to.

Thanks,
Arman
--
To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Bluez Devel]     [Linux Wireless Networking]     [Linux Wireless Personal Area Networking]     [Linux ATH6KL]     [Linux USB Devel]     [Linux Media Drivers]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Big List of Linux Books]

  Powered by Linux