Hi Jukka, On 16/09/14 08:04, Jukka Rissanen wrote: > Hi Martin, > > On ma, 2014-09-15 at 15:09 +0100, Martin Townsend wrote: >> Currently there are a number of error paths in the lowpan_rcv function that >> free the skb before returning, the patch simplifies the receive path by >> ensuring that the skb is only freed from this function. >> >> Passing the skb from 6lowpan up to the higher layers is not a >> function of IPHC. By moving it out of IPHC we also remove the >> need to support error code returns with NET_RX codes. >> It also makes the lowpan_rcv function more extendable as we >> can support more compression schemes. >> >> With the above 2 lowpan_rcv is refacored so eliminate incorrect return values. > I like the idea that we get rid of the callback function. > We could probably refactor the patch a bit further thou as the > lowpan_process_data() could return the skb directly instead of being > passed as a parameter. In the caller we could use the IS_ERR() macro to > check if the returned value is an error or a real pointer. > No probs, will respin v4 patch later. > Cheers, > Jukka > > - Martin. -- To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
