Hi, > -----Original Message----- > From: Luiz Augusto von Dentz [mailto:luiz.dentz@xxxxxxxxx] > Sent: Friday, September 12, 2014 2:16 AM > To: Gowtham Anandha Babu; linux-bluetooth@xxxxxxxxxxxxxxx; Dmitry > Kasatkin; Bharat Panda; cpgs@xxxxxxxxxxx > Subject: Re: [PATCH 1/7] obexd/client : Handle the MAP Extended Event > Report 1.1 > > Hi, > > On Thu, Sep 11, 2014 at 7:37 PM, Johan Hedberg > <johan.hedberg@xxxxxxxxx> wrote: > > Hi, > > > > On Thu, Sep 11, 2014, Gowtham Anandha Babu wrote: > >> struct map_event { > >> @@ -41,6 +42,10 @@ struct map_event { > >> char *folder; > >> char *old_folder; > >> char *msg_type; > >> + char *datetime; > >> + char *subject; > >> + char *sender_name; > >> + char *priority; > >> }; > > <snip> > >> +static void parse_event_report_date_time(struct map_event *event, > >> + const char > >> +*value) { > >> + event->datetime = g_strdup(value); } > >> + > >> +static void parse_event_report_subject(struct map_event *event, > >> + const char > >> +*value) { > >> + event->subject = g_strdup(value); } > >> + > >> +static void parse_event_report_sender_name(struct map_event > *event, > >> + const char > >> +*value) { > >> + event->sender_name = g_strdup(value); } > >> + > >> +static void parse_event_report_priority(struct map_event *event, > >> + const char > >> +*value) { > >> + event->priority = g_strdup(value); } > > > > Where are all these freed? Don't you need to update the > > map_event_free() function? If you're not yet doing so, please always > > test your code with "valgrind --leak-check=full". > > And it is mentioned in the HACKING document. > > -- > Luiz Augusto von Dentz I had sent the updated patch with freeing all the event attributes and tested with valgrind(No leak). Please have a look at it. Regards, Gowtham Anandha Babu -- To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
