Hi, On Thu, Sep 11, 2014 at 1:16 PM, Gowtham Anandha Babu <gowtham.ab@xxxxxxxxxxx> wrote: > Hi, > >> -----Original Message----- >> From: Szymon Janc [mailto:szymon.janc@xxxxxxxxx] >> Sent: Thursday, September 11, 2014 3:11 PM >> To: gowtham babu >> Cc: linux-bluetooth@xxxxxxxxxxxxxxx; d.kasatkin@xxxxxxxxxxx; >> bharat.panda@xxxxxxxxxxx; cpgs@xxxxxxxxxxx >> Subject: Re: [PATCH 3/3] android/hal-utils.c : Fix null pointer dereference >> >> Hi, >> >> On Wednesday 10 of September 2014 18:12:24 gowtham babu wrote: >> > Handles the possible null pointer dereference: bd_addr by checking it >> against null. >> > --- >> > android/hal-utils.c | 4 +++- >> > 1 file changed, 3 insertions(+), 1 deletion(-) >> > >> > diff --git a/android/hal-utils.c b/android/hal-utils.c index >> > ceefefc..64ab5a1 100644 >> > --- a/android/hal-utils.c >> > +++ b/android/hal-utils.c >> > @@ -166,11 +166,13 @@ int int2str_findstr(const char *str, const struct >> int2str m[]) >> > */ >> > const char *bt_bdaddr_t2str(const bt_bdaddr_t *bd_addr, char *buf) { >> > - const uint8_t *p = bd_addr->address; >> > + const uint8_t *p; >> > >> > if (!bd_addr) >> > return strcpy(buf, "NULL"); >> > >> > + p = bd_addr->address; >> > + >> > snprintf(buf, MAX_ADDR_STR_LEN, >> "%02x:%02x:%02x:%02x:%02x:%02x", >> > p[0], p[1], p[2], p[3], p[4], p[5]); >> > >> >> This patch looks OK to me, but I have one question before applying it. >> >> Do you really want your name to be visible in git history as it is in this email ie. >> without any capital letters? >> >> -- >> Best regards, >> Szymon Janc > > > Sorry for the top posting. Regarding the git name, that’s OK. Just be consistent, in this one you actually are using capital letter and a middle name. -- Luiz Augusto von Dentz -- To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
