Re: [PATCH][linux-bluetooth 1/3] 6lowpan: skb freed locally from lowpan_rcv

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Sep 11, 2014 at 09:58:30AM +0200, Alexander Aring wrote:
...
> >  
> > @@ -490,14 +490,14 @@ static int lowpan_rcv(struct sk_buff *skb, struct net_device *dev,
> >  	} else {
> >  		switch (skb->data[0] & 0xe0) {
> >  		case LOWPAN_DISPATCH_IPHC:	/* ipv6 datagram */
> > -			ret = process_data(skb, &hdr);
> > +			ret = process_data(&skb, &hdr);
> >  			if (ret == NET_RX_DROP)
> >  				goto drop;
> 
> the conversion from errno to NET_RX_DROP here.
> 
> if (ret < 0)
>         goto drop;
> 

should be more drop_skb here, since we removed the kfree_skb in
process_data. ... I know the error handling is a mess, but was also
before I start to working with it. :-)

Thanks, that you accept this challenge to fix it. ;-)

- Alex
--
To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Bluez Devel]     [Linux Wireless Networking]     [Linux Wireless Personal Area Networking]     [Linux ATH6KL]     [Linux USB Devel]     [Linux Media Drivers]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Big List of Linux Books]

  Powered by Linux