HI Johan, >> >> + unsigned int notify_id, indic_id; >> > >> > I have never seen indication shorted into indic. I have to say that >> > I do not like it that much. However I do not have any good >> > suggestion either. >> > >> >> Perhaps "indicn_id"? I could just spell out "indication_id" :P. > > What's wrong with "ind"? It's used in many places in the tree as a > shorthand for indication and even shared/att.c uses it. On the other > hand if you want to match the grammatical form of notify_id you should > use indicate_id (which feels much worse to me). Third option that comes > to mind if we want short versions of both is "ind" and "nfy", but not > sure how decipherable the latter is. > I initially had "ind" for indication and "not" for notification (which seemed to be consistent with other places in the code, as you said), though Marcel didn't like those :P I guess "ind" isn't super suggestive of "indication" and, as Marcel pointed out earlier, "not" is easily confused as "negation" rather than "notification. I personally prefer not to shorten them at all and spell out "notification_id" and "indication_id", which I find the most readable. I only started contracting things after mailing list feedback saying not to use long names. In the end it doesn't matter what these are called if their declaration is accompanied by an explanatory comment. "ind_id" and "ntfy_id" look fine to me. -Arman -- To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
