Re: [PATCH] audio/avdtp: Fix invalid reference counting

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Vinicius,

On Wed, Aug 20, 2014 at 5:06 PM, Vinicius Costa Gomes <vcgomes@xxxxxxxxx> wrote:
> If the AVDTP session is terminated via any other mean than
> 'connection_lost()' (the only place that btd_device_unref() was called),
> there was a dangling reference to the device.
>
> This can be easily reproduced by suspending the host while using an A2DP
> speaker. It has the very misleading effect of being unable to create the
> device when the system resumes.
> ---
>  profiles/audio/avdtp.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/profiles/audio/avdtp.c b/profiles/audio/avdtp.c
> index 8a7d1c0..ba5f0e5 100644
> --- a/profiles/audio/avdtp.c
> +++ b/profiles/audio/avdtp.c
> @@ -1135,6 +1135,7 @@ static void avdtp_free(void *data)
>
>         g_free(session->buf);
>
> +       btd_device_unref(session->device);
>         g_free(session);
>  }
>
> @@ -1160,7 +1161,6 @@ static void connection_lost(struct avdtp *session, int err)
>                 return;
>
>         server->sessions = g_slist_remove(server->sessions, session);
> -       btd_device_unref(session->device);
>         avdtp_free(session);
>  }
>
> --
> 2.0.4

Nice catch, Ive been hunting this very problem for some time.

Applied, thanks.


-- 
Luiz Augusto von Dentz
--
To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Bluez Devel]     [Linux Wireless Networking]     [Linux Wireless Personal Area Networking]     [Linux ATH6KL]     [Linux USB Devel]     [Linux Media Drivers]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Big List of Linux Books]

  Powered by Linux