Re: [PATCH] tools/l2test: And listen and not receive mode option

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Johan,

On 13 August 2014 11:22, Johan Hedberg <johan.hedberg@xxxxxxxxx> wrote:
> Hi Lukasz,
>
> On Wed, Aug 13, 2014, Lukasz Rymanowski wrote:
>> +static void not_receive_mode(int sk) {
>> +
>> +     syslog(LOG_INFO, "Connected and not receiving !");
>> +     while (1) {};
>> +}
>
> A busy-loop taking up all CPU time doesn't seem very nice. Shouldn't you
> instead be at least polling for HUP/ERR events? That's what the
> do_listen function seems to expect to have happened when the handler
> returns.
>
You are right, even it is test tool. Anyway, we don't need that patch
at all as wrote in other email.

> Johan

Lukasz
--
To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Bluez Devel]     [Linux Wireless Networking]     [Linux Wireless Personal Area Networking]     [Linux ATH6KL]     [Linux USB Devel]     [Linux Media Drivers]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Big List of Linux Books]

  Powered by Linux