Hi Arman, >>> struct bt_att { >>> int ref_count; >>> int fd; >>> - bool close_on_unref; >> >> I like to keep the close_on_unref logic. So please do not remove it. >> > > I removed this flag in favor of directly calling > io_set_close_on_destroy in bt_att_set_close_on_unref, which achieves > the same thing. Is it better to have a separate flag and not use > io_set_close_on_destroy at all? good question. I have no idea. If the feature is still there, then I do not care either way. However such a change might be better done in a separate patch. Regards Marcel -- To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html