Hi Andrei, On Tue, Aug 12, 2014, Andrei Emeltchenko wrote: > MAX_PACKET_SIZE is defined in many places and NEVER explained. > > 1 45 android/bluetoothd-snoop.c <<MAX_PACKET_SIZE>> > #define MAX_PACKET_SIZE (1486 + 4) > 2 42 monitor/analyze.c <<MAX_PACKET_SIZE>> > #define MAX_PACKET_SIZE (1486 + 4) > 3 55 monitor/control.c <<MAX_PACKET_SIZE>> > #define MAX_PACKET_SIZE (1486 + 4) > 4 47 src/shared/btsnoop.h <<MAX_PACKET_SIZE>> > #define MAX_PACKET_SIZE (1486 + 4) Let's fix that then and explain it in the code. > Maybe insetad of btsnoop.h I define it in src/shared/btsnoop.c Sounds to me like all those places include btsnoop.h, meaning a common define in btsnoop.h might be the best way forward. Johan -- To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
