Hi Marcel, > > > + ret = btmrvl_send_sync_cmd(priv, BT_CMD_SET_BDADDR, buf, sizeof(buf)); > > > > So I keep wondering why you need the btmrvl_send_sync_cmd here. The HCI transport is up and running > > at this stage and sending vendor command should do the right thing. Similar to what you do in btusb > > driver. > > > > You might have explained this to, but I must have clearly not understood it. > > We will check if btmrvl_send_sync_cmd() can be replaced by __hci_cmd_sync() and get back to you. __hci_cmd_sync() sets skb->packet_type as 0x01 whereas btmrvl_send_sync_cmd() sets it as 0xfe. But the firmware handles both 0x01 and 0xfe tx packets in similar way. Therefore we can replace btmrvl_send_sync_cmd() with __hci_cmd_sync(). I will send a v2 for this patch shortly. Later on we will send out a cleanup patch for other existing commands that are using btmrvl_send_sync_cmd(). Thanks, Bing -- To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
