Re: [RFC v3 3/4] Bluetooth: Enable new LE meta event

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Andre,

> The Bluetooth 4.1 introduces a new LE meta event called "LE Remote
> Connection Parameter Request" event. In order to the controller
> sends this event to host, we should enable it during controller
> initialization.
> 
> Signed-off-by: Andre Guedes <andre.guedes@xxxxxxxxxxxxx>
> ---
> include/net/bluetooth/hci.h | 3 +++
> net/bluetooth/hci_core.c    | 7 +++++++
> 2 files changed, 10 insertions(+)

patch has been applied to bluetooth-next tree.

> diff --git a/include/net/bluetooth/hci.h b/include/net/bluetooth/hci.h
> index 95b7547..66358af 100644
> --- a/include/net/bluetooth/hci.h
> +++ b/include/net/bluetooth/hci.h
> @@ -307,6 +307,9 @@ enum {
> #define LMP_HOST_LE_BREDR	0x04
> #define LMP_HOST_SC		0x08
> 
> +/* LE features */
> +#define HCI_LE_CONN_PARAM_REQ_PROC	0x02
> +
> /* Connection modes */
> #define HCI_CM_ACTIVE	0x0000
> #define HCI_CM_HOLD	0x0001
> diff --git a/net/bluetooth/hci_core.c b/net/bluetooth/hci_core.c
> index 5788e03..8a54ca2 100644
> --- a/net/bluetooth/hci_core.c
> +++ b/net/bluetooth/hci_core.c
> @@ -1611,6 +1611,13 @@ static void hci_init3_req(struct hci_request *req, unsigned long opt)
> 
> 		memset(events, 0, sizeof(events));
> 		events[0] = 0x1f;
> +
> +		/* If controller supports the Connection Parameters Request
> +		 * Link Layer Procedure, enable the corresponding event.
> +		 */
> +		if (hdev->le_features[0] & HCI_LE_CONN_PARAM_REQ_PROC)
> +			events[0] = events[0] | 0x20;
> +

However I fixed this to do this properly:

			events[0] |= 0x20;

We used this everywhere else. No idea why you had to make it so complicated ;)

Regards

Marcel

--
To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Bluez Devel]     [Linux Wireless Networking]     [Linux Wireless Personal Area Networking]     [Linux ATH6KL]     [Linux USB Devel]     [Linux Media Drivers]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Big List of Linux Books]

  Powered by Linux