Hi, Thanks for the fast review! On Tue, Jul 1, 2014 at 10:26 AM, Marcel Holtmann <marcel@xxxxxxxxxxxx> wrote: >> + chip_id = (uint16_t *)(epatch_fw->data + >> + sizeof(struct rtk_epatch_header)); >> + patch_length = (uint16_t *)((unsigned char *) chip_id + >> + (sizeof(uint16_t) >> + * epatch_info->num_patches)); >> + patch_offset = (uint32_t *)((unsigned char *) patch_length + >> + (sizeof(uint16_t) >> + * epatch_info->num_patches)); > > Using the unaligned helpers is not an option? Can you go into a bit more detail here? I should indeed use get_unaligned for accessing the 32-bit patch_offset values as they might not be 4-byte aligned. The others should be fine though. Or are you suggesting some helper that I can use to clean up the code in this area? If so, could you be a little more specific? > Do you really want to name the directory rtl_bt and not rtk or realtek or something more that makes actually sense. I have no idea where rtl comes from. There is already /lib/firmware/rtl_nic used by r8169 driver, I was going for consistency with that. There is also /lib/firmware/rtlwifi. Does that influence your preference? I'll address all other comments in the next patch. Thanks Daniel -- To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
