Hi, On Mon, Jun 30, 2014 at 12:26 PM, Amith Raghunath <Amith.Raghunath@xxxxxxxxxxxxxxxxxxx> wrote: > Hi Marcel/John, > We are planning to contribute a BLE Findme profile for the "Locator Role" to the Bluez Stack. > It is around 300 lines of code (excluding comments & blank lines). > We request your kind self to let us know the following: > a) Approximate time that it would take for this code to get reviewed. > b) The procedure to add this file to the Bluez GIT The guidelines are about the same for kernel and userspace, so you are suppose to provide a with proper git patches (git format-patch + git send-email). Regarding the profile itself I would probably hold on to use the new infrastructure from bt_gatt or do as we did with BAS, DIS and HoG in android where we use GAttrib only internally. I would probably suggest creating LGPL helpers under src/shared/ before the implementing any plugin, e.g.: - bt_<profile>_new(primary): Allocate the data structures - bt_<profile>_attach(instance, connection): On the first attach you are suppose to discover the handles and cache them, once the handle are cached then you can proceed with notification and read/write operations required by the profile. - bt_<profile>_detach(instance): Unref any connection reference and cleanup any notification etc. - bt_<profile>_set_notification(instance, callback, data): This is optional in case the profile does provide notifications. - bt_<profile>_unref: Detach and free the data structures -- Luiz Augusto von Dentz -- To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
