Re: [PATCH v5 0/4] bt_att initial implementation

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Marcel,

> However, you really need to use a proper compiler that gives you a decent amount of warnings.
>
>   CC       src/shared/bluetoothd-att.o
> src/shared/att.c: In function ‘encode_pdu’:
> src/shared/att.c:194:2: error: label ‘dafault’ defined but not used [-Werror=unused-label]
>   dafault:
>   ^
> src/shared/att.c: In function ‘handle_error_rsp’:
> src/shared/att.c:447:8: error: unused variable ‘result’ [-Werror=unused-variable]
>   bool result;
>         ^
> src/shared/att.c: In function ‘handle_mtu_rsp’:
> src/shared/att.c:464:8: error: unused variable ‘result’ [-Werror=unused-variable]
>   bool result;
>         ^
> src/shared/att.c: In function ‘bt_att_set_mtu’:
> src/shared/att.c:689:11: error: pointer targets in assignment differ in signedness [-Werror=pointer-sign]
>   att->buf = buf;
>            ^
>
> I fixed them all up for you since they were dead simple fixes, but please be a bit more careful for the next set of patches.
>

Thanks for doing that. I've been compiling for Chrome OS using the
portage based toolchain, which really just runs the included configure
scripts and compiles with gcc. I'll just explicitly stick in -Werror
somewhere next time.

Thanks!
Arman
--
To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Bluez Devel]     [Linux Wireless Networking]     [Linux Wireless Personal Area Networking]     [Linux ATH6KL]     [Linux USB Devel]     [Linux Media Drivers]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Big List of Linux Books]

  Powered by Linux