This patch allows to pair with devices using RPA. There is no API
to notify HAL about new Identity Address. When New IRK event is
received ID address is stored in device and map to RPA is done.
This allows to use RPA after address was resolved making this
transparent to Android Framework. When daemon is restarted device
is advertised to Framework with ID address.
---
android/bluetooth.c | 83 +++++++++++++++++++++++++++++++++++++++++++++++------
1 file changed, 74 insertions(+), 9 deletions(-)
diff --git a/android/bluetooth.c b/android/bluetooth.c
index c664461..166337f 100644
--- a/android/bluetooth.c
+++ b/android/bluetooth.c
@@ -127,6 +127,11 @@ struct device {
bdaddr_t bdaddr;
uint8_t bdaddr_type;
+ bdaddr_t rpa_bdaddr;
+ uint8_t rpa_bdaddr_type;
+
+ bool rpa;
+
bool le;
bool bredr;
@@ -220,7 +225,10 @@ static struct ipc *hal_ipc = NULL;
static void get_device_android_addr(struct device *dev, uint8_t *addr)
{
- bdaddr2android(&dev->bdaddr, addr);
+ if (dev->rpa)
+ bdaddr2android(&dev->rpa_bdaddr, addr);
+ else
+ bdaddr2android(&dev->bdaddr, addr);
}
static void mgmt_debug(const char *str, void *user_data)
@@ -382,6 +390,9 @@ static int device_match(gconstpointer a, gconstpointer b)
const struct device *dev = a;
const bdaddr_t *bdaddr = b;
+ if (dev->rpa && !bacmp(&dev->rpa_bdaddr, bdaddr))
+ return 0;
+
return bacmp(&dev->bdaddr, bdaddr);
}
@@ -689,7 +700,7 @@ void bt_store_gatt_ccc(const bdaddr_t *dst, uint16_t value)
return;
}
- ba2str(dst, addr);
+ ba2str(&dev->bdaddr, addr);
DBG("%s Gatt CCC %d", addr, value);
@@ -1642,12 +1653,21 @@ static void update_found_device(const bdaddr_t *bdaddr, uint8_t bdaddr_type,
/* Notify Gatt if its registered for LE events */
if (bdaddr_type != BDADDR_BREDR && gatt_device_found_cb) {
bool discoverable;
+ bdaddr_t *addr;
+ uint8_t addr_type;
discoverable = eir.flags & (EIR_LIM_DISC | EIR_GEN_DISC);
- gatt_device_found_cb(bdaddr, bdaddr_type, rssi, data_len, data,
- discoverable,
- dev->le_bonded);
+ if (dev->rpa) {
+ addr = &dev->rpa_bdaddr;
+ addr_type = dev->rpa_bdaddr_type;
+ } else {
+ addr = &dev->bdaddr;
+ addr_type = dev->bdaddr_type;
+ }
+
+ gatt_device_found_cb(addr, addr_type, rssi, data_len, data,
+ discoverable, dev->le_bonded);
}
if (!dev->bredr_paired && !dev->le_paired)
@@ -2078,10 +2098,55 @@ static void new_irk_callback(uint16_t index, uint16_t length,
DBG("new IRK for %s, RPA %s", dst, rpa);
- /* TODO: handle new Identity to RPA mapping */
- dev = find_device(&addr->bdaddr);
- if (!dev)
- return;
+ if (!bacmp(&ev->rpa, BDADDR_ANY)) {
+ dev = find_device(&addr->bdaddr);
+ if (!dev)
+ return;
+ } else {
+ dev = find_device(&addr->bdaddr);
+
+ if (dev && dev->bredr_paired) {
+ dev->rpa = true;
+ bacpy(&dev->rpa_bdaddr, &addr->bdaddr);
+ dev->rpa_bdaddr_type = addr->type;
+
+ /* TODO merge properties ie. UUIDs */
+ } else {
+ /*
+ * remove device with same address if it was in cache
+ * but not paired (ie was unpaired in past or seen over
+ * BR/EDR
+ *
+ * TODO merge props before removing?
+ */
+ if (dev) {
+ cached_devices = g_slist_remove(cached_devices,
+ dev);
+ remove_device_info(dev, CACHE_FILE);
+ free_device(dev);
+
+
+ DBG("TEGES %p", dev = find_device(&addr->bdaddr));
+ }
+
+ dev = find_device(&ev->rpa);
+ if (!dev)
+ return;
+
+ /* don't leave garbage in cache file */
+ remove_device_info(dev, CACHE_FILE);
+
+ dev->rpa = true;
+ bacpy(&dev->rpa_bdaddr, &dev->bdaddr);
+ dev->rpa_bdaddr_type = dev->bdaddr_type;
+
+ bacpy(&dev->bdaddr, &addr->bdaddr);
+ dev->bdaddr_type = addr->type;
+ }
+ }
+
+ update_device_state(dev, ev->key.addr.type, HAL_STATUS_SUCCESS, false,
+ true, !!ev->store_hint);
if (ev->store_hint)
store_irk(dev, ev->key.val);
--
1.9.3
--
To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
