Hi Andrei, On Monday 16 June 2014 10:57:48 Andrei Emeltchenko wrote: > From: Andrei Emeltchenko <andrei.emeltchenko@xxxxxxxxx> > > The code does not have effect. > --- > android/hal-audio.c | 3 --- > 1 file changed, 3 deletions(-) > > diff --git a/android/hal-audio.c b/android/hal-audio.c > index 6d2ef3a..36f1f3f 100644 > --- a/android/hal-audio.c > +++ b/android/hal-audio.c > @@ -286,9 +286,6 @@ static int audio_ipc_cmd(uint8_t service_id, uint8_t > opcode, uint16_t len, goto failed; > } > > - if (rsp_len) > - *rsp_len = cmd.len; > - > return AUDIO_STATUS_SUCCESS; > > failed: This is not correct. rsp_len is also output parameter for this function. If caller expects response it should verify it before accessing response. (although since rsp_len was already dereferenced before null check is not really needed here) -- Szymon K. Janc szymon.janc@xxxxxxxxx -- To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
