Re: [PATCH v4 0/4] bt_att initial implementation

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Arman,

> v4:
>  - Changed get_op_type from a big switch statement to a function that walks a
>  static const array that represents a table of ATT opcodes and their types.
>  - Single bt_att_register function for incoming requests and notifications/
>  indications.
>  - Replaced bt_att_set_auth_signature with bt_att_set_signing_data, which takes
>  in the CSRK and the sign counters, which will be used to generate the
>  authentication signature for outgoing signed PDUs and to verify incoming
>  signed PDUs.
>  - Added bt_att_set_timeout_cb. Added a 30 second timeout for pending requests,
>  after which the user will be notified and bt_att invalidated.
>  - Moved parameter structure, opcode, and error code definitions to
>  src/shared/att-types.h

so besides minor cosmetic changes and leaving the CSRK detail our for now, this looks good.

Johan, Luiz, have an extra look, but I think v5 should be ready to be merged.

Regards

Marcel

--
To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Bluez Devel]     [Linux Wireless Networking]     [Linux Wireless Personal Area Networking]     [Linux ATH6KL]     [Linux USB Devel]     [Linux Media Drivers]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Big List of Linux Books]

  Powered by Linux