Hi Vikram, On Wed, Jun 11, 2014, vikrampal wrote: > Signed-off-by: vikrampal <vikram.pal@xxxxxxxxxxx> We don't use Signed-off-by for user space patches so please remove this. Also, add an "sdp: " prefix to the commit summary, use the consistent form of the opening verb, i.e. "Fix" instead of "Fixed" and please provide some short explanation in the commit message body as well. You'll also need to fix up your git author information to be of the format "Firstname Lastname <email>" (right now you just have "vikrampal" as your name). > --- > src/sdp-xml.c | 16 +++++++++++++++- > src/sdpd-database.c | 4 ++++ > 2 files changed, 19 insertions(+), 1 deletion(-) Besides the mentioned cosmetic things the patch looks quite good. Johan -- To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
