Re: [PATCH] android/hal-audio: Fix memory leak

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Andrei,

On 5 June 2014 16:51, Andrei Emeltchenko
<Andrei.Emeltchenko.news@xxxxxxxxx> wrote:
> From: Andrei Emeltchenko <andrei.emeltchenko@xxxxxxxxx>
>
> Fixes clang warning:
> ...
> android/hal-audio.c:484:3: warning: Potential leak of memory pointed to
> by 'preset'
> ...
> ---
>  android/hal-audio.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/android/hal-audio.c b/android/hal-audio.c
> index 439b583..4d3cdb1 100644
> --- a/android/hal-audio.c
> +++ b/android/hal-audio.c
> @@ -482,6 +482,7 @@ static bool open_endpoint(struct audio_endpoint **epp,
>
>         if (!ep) {
>                 error("Cound not find opened endpoint");
> +               free(preset);
>                 return false;
>         }

I'd rather do 'goto failed' here so we also close fd.

BR,
Andrzej
--
To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Bluez Devel]     [Linux Wireless Networking]     [Linux Wireless Personal Area Networking]     [Linux ATH6KL]     [Linux USB Devel]     [Linux Media Drivers]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Big List of Linux Books]

  Powered by Linux