Re: [PATCH 1/2] tools/btmgmt: Add set-io-cap command

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Lukasz,

On Tue, May 27, 2014, Lukasz Rymanowski wrote:
> +static void cmd_set_io_cap(struct mgmt *mgmt, uint16_t index,
> +						int argc, char **argv)
> +{
> +	struct mgmt_cp_set_io_capability cp;
> +	uint8_t cap = 0x01;

No reason to set this here as you anyway overwrite it later.

> +	cap = atoi(argv[1]);

strtol makes more sense (to support hex too) and is consistent to how
this is decoded for the pair command.

Since I needed this feature myself I fixed these things up with --amend
and pushed the patch. Thanks.

Johan
--
To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Bluez Devel]     [Linux Wireless Networking]     [Linux Wireless Personal Area Networking]     [Linux ATH6KL]     [Linux USB Devel]     [Linux Media Drivers]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Big List of Linux Books]

  Powered by Linux