Re: [PATCH v2 4/8] Bluetooth: l2cap: Set more channel defaults

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Jukka,

> Signed-off-by: Jukka Rissanen <jukka.rissanen@xxxxxxxxxxxxxxx>
> ---
> net/bluetooth/l2cap_core.c | 6 ++++++
> 1 file changed, 6 insertions(+)
> 
> diff --git a/net/bluetooth/l2cap_core.c b/net/bluetooth/l2cap_core.c
> index 60433c4..3a7f560 100644
> --- a/net/bluetooth/l2cap_core.c
> +++ b/net/bluetooth/l2cap_core.c
> @@ -471,8 +471,14 @@ void l2cap_chan_set_defaults(struct l2cap_chan *chan)
> 	chan->max_tx = L2CAP_DEFAULT_MAX_TX;
> 	chan->tx_win = L2CAP_DEFAULT_TX_WINDOW;
> 	chan->tx_win_max = L2CAP_DEFAULT_TX_WINDOW;
> +	chan->remote_max_tx = chan->max_tx;
> +	chan->remote_tx_win = chan->tx_win;
> 	chan->ack_win = L2CAP_DEFAULT_TX_WINDOW;
> 	chan->sec_level = BT_SECURITY_LOW;
> +	chan->flush_to = L2CAP_DEFAULT_FLUSH_TO;
> +	chan->retrans_timeout = L2CAP_DEFAULT_RETRANS_TO;
> +	chan->monitor_timeout = L2CAP_DEFAULT_MONITOR_TO;
> +	chan->conf_state = 0;

this one extremely bad without a detailed commit message explaining why the change is made.

Regards

Marcel

--
To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Bluez Devel]     [Linux Wireless Networking]     [Linux Wireless Personal Area Networking]     [Linux ATH6KL]     [Linux USB Devel]     [Linux Media Drivers]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Big List of Linux Books]

  Powered by Linux